Skip to content

dhcp/dns offload feature config dirve changes for vm migration#568

Closed
jayapalu wants to merge 4 commits intomasterfrom
dhcpnew
Closed

dhcp/dns offload feature config dirve changes for vm migration#568
jayapalu wants to merge 4 commits intomasterfrom
dhcpnew

Conversation

@jayapalu
Copy link
Contributor

@jayapalu jayapalu commented Jul 9, 2015

Added vm migration changes for config drive.
Added integration test for this.

@asfbot
Copy link

asfbot commented Jul 9, 2015

cloudstack-pull-rats #22 SUCCESS
This pull request looks good

@asfbot
Copy link

asfbot commented Jul 9, 2015

cloudstack-pull-requests #717 UNSTABLE
Looks like there's a problem with this pull request

sanju1010
sanju1010 reviewed Jul 9, 2015
View reviewed changes
test/integration/component/test_dhcp_dns_offload.py
Copy link
Contributor

@sanju1010 sanju1010 Jul 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to comment this if DHCP Server is available in the shared network broadcast domain while running tests. Looks good to me.

@kishankavala
Copy link
Contributor

kishankavala commented Jul 9, 2015

Looks good to me.
Commented on older PR earlier.
PR #552 can be removed

@asfgit asfgit closed this in 3df847d Jul 10, 2015
@asfbot
Copy link

asfbot commented Jul 10, 2015

Daan Hoogland on dev@cloudstack.apache.org replies:
I don't see two LGTM on this one. What happened?

@sateesh-chodapuneedi
Copy link
Member

sateesh-chodapuneedi commented Jul 10, 2015

@DaanHoogland

I think there are 2 LGTM on this one - from @sanju1010 & @kishankavala

sanju1010 added a note a day ago
Need to comment this if DHCP Server is available in the shared network broadcast domain while >running tests. Looks good to me.

kishankavala commented a day ago
Looks good to me.
Commented on older PR earlier.
PR #552 can be removed

@asfbot
Copy link

asfbot commented Jul 10, 2015

Daan Hoogland on dev@cloudstack.apache.org replies:
my bad, I would like to see "$LGTM" (as in on the start of a line),
though. This looks like a comment at first.

yadvr pushed a commit that referenced this pull request Jan 20, 2021
@yadvr
npm: Build and packaging improvements (#568)
64d95fb 
* remove unused plugins and minimizer js

* update dependencies

* fix build, update dependencies

* using lazy_use components

* add additional components

* optimization: lazy loading i18n locales

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jayapalu @asfbot @kishankavala @sateesh-chodapuneedi @sanju1010